Use maven-jar-plugin to attach the custom manifest file#124
Conversation
previously the maven-shade-plugin was used for this purpose which causes the issue that the manifest file is not at the beginning of the JAR stream which is required by the JarInputStream implementation.
|
@bjorndarri Can you please verify that this resolves your issue? repositories {
//all your default repositories...
maven {
url "https://oss.sonatype.org/content/repositories/comgithublgooddatepicker-1030"
}
} |
|
At first glance it looks like this solves the problem, I'll do some further testing in a properly modular project tonight, I'll report back. |
|
Couldn't wait, finished testing this and I can confirm that this does indeed solve the problem. ps. sorry about that weird solution proposed yesterday, I was so deep down the debugging rabbit hole, having spent hours searching for a solution that I just jumped on the first thing that looked like it fixed the problem, even though it was so obviously wrong :). |
|
No worries, tunnel vision on the bug hunt happens to everyone 🙂. You left enough bread crumbs for me to find the root cause, that is what matters 👍 Thank you for taking the time to verify my solution. FYI the release process for LGoodDatePicker |
This PR provides
Using the maven-shade-plugin to attach the custom manifest file leads to the issue that the manifest file is not at the beginning of the JAR stream. This is resolved by using the maven-jar-plugin to attach the custom manifest file.