Skip to content

Add new domain_socket data type#33

Merged
lukebakken merged 2 commits intoKyorai:masterfrom
codeadict:uds_datatype
Feb 13, 2023
Merged

Add new domain_socket data type#33
lukebakken merged 2 commits intoKyorai:masterfrom
codeadict:uds_datatype

Conversation

@codeadict
Copy link
Copy Markdown
Contributor

@codeadict codeadict commented Feb 3, 2023 •
edited
Loading

Adds domain_socket as a new datatype, separate from the existing ip but with the convenience of parsing "local:/path/to/your.sock:0" or "unix:/path/to/your.sock:0" into {local, "/path/to/your.sock", 0} , following the type at https://www.erlang.org/doc/man/inet.html#type-local_address.

This was referenced Feb 6, 2023
Closed
Merged
ioolkos
ioolkos approved these changes Feb 10, 2023
View reviewed changes
Copy link
Copy Markdown

@ioolkos ioolkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll use this in VerneMQ and think it's a useful datatype to add to Cuttlefish.

@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

Thanks @ioolkos, pinging @michaelklishin @lukebakken for visibility.

@michaelklishin
Copy link
Copy Markdown
Collaborator

michaelklishin commented Feb 13, 2023

Something is off with Erlang provisioning on Actions.

I don't have any objections to adding this new data type.

@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

Thanks, i know wbat the GHA problem is, going to fix it here

@lukebakken
Copy link
Copy Markdown
Collaborator

lukebakken commented Feb 13, 2023 •
edited
Loading

@codeadict thanks for pinging me. I didn't get or didn't notice an email about this PR.

Thanks for taking a look at GHA!

@lukebakken lukebakken self-assigned this Feb 13, 2023
@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

Awesome @lukebakken , you can give a shot now to running the Github actions 🤞🏽

@lukebakken lukebakken mentioned this pull request Feb 13, 2023
Merged
@lukebakken lukebakken added this to the 3.2.0 milestone Feb 13, 2023
@codeadict @lukebakken
parent 6a016f2
1972c39 
author Dairon Medina Caro <dmedinacaro@cars.com> 1674855971 -0500
committer Luke Bakken <luke@bakken.io> 1676314181 -0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQJDBAABCAAtFiEEsbgswM+EunAUfr0F2Z3jDkPq5EAFAmPqhkUPHGx1a2VAYmFr
 a2VuLmlvAAoJENmd4w5D6uRAdOIP/1f/JeDldc5ygq164ERRa6VbUGSQTluHEY/o
 0pXfs5nelmfws2e12MFyvxK8ar+qLg/XyN6Y/HUZBFLgwX/qwsgwDtZv8uT0X4bW
 1yb26UsG22Q/oIv3aBYOGl/Nrkqch+Pw2TGJBynSIznYVXqDOd+LbQG5aXrZbfCd
 2xMpESnGeCFTsEpjgsNZu7vPKeDjBHeCN24EMi2DtPaC9xzb4PHhriDvCgS2YdpX
 bhjmFfAUv0v27PS+6GN7SqygRkRgiplpvEM3ToNVePS6lPdMpz6dsOO1NFcnzmY/
 +AT+okaILgIGwof/nF2QFtbEMkzTSnml9P7FtsaDjlrTmn9yVEN5q5hoHSVBaTMS
 ISmOFGKsx3W5YJtgb4gp0UzSAktK9e1jjhcd7160hO/DCv7LvzC33lJVHlXK0Ep6
 vvRuOfbdhFOIFsTUBqz7cHoCIckz7smlohFi57znKop3DINEsq9cnbFBaqSKTAzE
 r+KRZOxQpc9Fv1j69DS6ASfM4gv9vPjgCJaTDRI4XZKUY6WWJCfxkY8pN4h6RLMz
 AhyDp/4IpDr8wafCg8dZcIgrDSnY+sWd3RkSaiWp4TfOjtFWb+D1gpyuBfgaZWHV
 1clNDvI2A7TJpJVOArhZpBfqFHijJwCuVzuGYkBTAOaowiJGNkk9kVOtdgq4b32R
 m7kRBCZ2
 =k54M
 -----END PGP SIGNATURE-----

Add support for Unix Domain Sockets type

Simplify domain sockets

Validate only 0 port can be provided

Use same format expected by inets

ci: Normalize GHA string quotes
lukebakken
lukebakken approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lukebakken lukebakken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeadict some of the quoting changes in the GHA workflow file were invalid. I like single quotes anyway 😉 Waiting for GHA to finish then I'll merge.

PS I cherry-picked your changes into #34

lukebakken
lukebakken requested changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dialyzer failed:

src/cuttlefish_datatypes.erl
Line 332 Column 1: The pattern <String, _UDSStr, _, 'undefined'> can never match the type <string(),string(),{'match',nonempty_string()},0>
===> Warnings written to _build/default/25.2.2.dialyzer_warnings
===> Warnings occurred running dialyzer: 1

@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

Thanks @lukebakken . Yeah no hard opinion on the quotes, my editor as changing them all the time on save to double quotes but i just figured it was the prettier extension I had enabled.

@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

🎉

@lukebakken lukebakken merged commit be90c7d into Kyorai:master Feb 13, 2023
@lukebakken
Copy link
Copy Markdown
Collaborator

lukebakken commented Feb 13, 2023 •
edited
Loading

@ioolkos @codeadict here you go!

https://github.com/Kyorai/cuttlefish/releases/tag/v3.2.0

THANKS!

PS I'm getting hex.pm right now...

@lukebakken
Copy link
Copy Markdown
Collaborator

lukebakken commented Feb 13, 2023

https://hex.pm/packages/cuttlefish/3.2.0

@ioolkos
Copy link
Copy Markdown

ioolkos commented Feb 13, 2023

Yay, thanks @lukebakken! :)

@codeadict
Copy link
Copy Markdown
Contributor Author

codeadict commented Feb 13, 2023

Thanks a lot. cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukebakken lukebakken lukebakken requested changes

+1 more reviewer

@ioolkos ioolkos ioolkos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukebakken lukebakken

Labels

None yet

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@codeadict @michaelklishin @lukebakken @ioolkos