[CH-45]support count(*/count(1)#175
Merged
liuneng1994 merged 3 commits intoKyligence:clickhouse_backendfrom Oct 31, 2022
Merged
[CH-45]support count(*/count(1)#175liuneng1994 merged 3 commits intoKyligence:clickhouse_backendfrom
liuneng1994 merged 3 commits intoKyligence:clickhouse_backendfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
da975ce to
d2d27ef
Compare
Author
|
test this please with 398 |
Author
|
test this please with 398 |
4e9d1b0 to
c3c95af
Compare
Author
|
test this please with 398 |
1 similar comment
Author
|
test this please with 398 |
support count(*)/count(1)
c3c95af to
dfdb9b6
Compare
Author
|
test this please with 398 |
1 similar comment
Author
|
test this please with 398 |
Author
|
test this please with 398 |
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support count(*)/count(1)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
relate to issue #45
Read from file sources or java batch iterator will fail with empty columns to read. This happends when running the following queries.
In this case, the rows number is the only information to need. To solve this, we try to build a block with an virtual column which indicates the rows number, and this virtual column will not be really used.
In
SubstraitFileSource, if the file implementgetTotalRows, we build blocks with a constant column whose total size is equal togetTotalRows's result.In
SourceFromJavaIter, we also return blocks with a constant column whose size is equal to input block's rows.For merge tree, we try to read a least one column instead of the original empty header.