Skip to content

refactor opsStatus #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ColdsteelRail merged 18 commits into from
Sep 2, 2024
Merged

refactor opsStatus #252

ColdsteelRail merged 18 commits into from
Sep 2, 2024

Conversation

@ColdsteelRail
Copy link
Member

@ColdsteelRail ColdsteelRail commented Aug 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.28571% with 46 lines in your changes missing coverage. Please review.

Project coverage is 65.93%. Comparing base (a4875fb) to head (9657061).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...g/controllers/operationjob/operationjob_manager.go 33.84% 41 Missing and 2 partials ⚠️
...ontrollers/operationjob/operationjob_controller.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   66.17%   65.93%   -0.25%     
==========================================
  Files          78       78              
  Lines        5538     5548      +10     
==========================================
- Hits         3665     3658       -7     
- Misses       1519     1536      +17     
  Partials      354      354
Flag Coverage Δ
unittests 65.93% <34.28%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail changed the title remove progress FinishingOpsLifecycle refactor opsStatus Aug 22, 2024
@ColdsteelRail
Copy link
Member Author

ColdsteelRail commented Sep 2, 2024

(1) refactor opsStatus: move reason message into error, and add the extraInfo, remove endingLifecycle progress
(2) refactor actionHandler interface
(3) improve pending -> processing

@ColdsteelRail ColdsteelRail merged commit 7458332 into main Sep 2, 2024
@ColdsteelRail ColdsteelRail deleted the refactor-opsstatus branch September 2, 2024 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shaofan-hs shaofan-hs shaofan-hs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力

3 participants

@ColdsteelRail @shaofan-hs