Merged
Conversation
Owner
|
really appreciate the pr could you make sure to pull all the latest changes first and if possible make it so pressing q takes the user back to the videos list instead of the search |
Contributor
Author
|
Yeah, I can do that — but it might take a bit of time. |
Owner
|
Sure, no problem take your time |
Contributor
Author
|
I've added all the changes you asked. Please let me know if you want any further modifications. |
Owner
|
@mojahid8238 good job btw there's a merge conflict in internal/app/modes.go. Can you pull the latest main and resolve it on your side? |
Contributor
Author
|
@KrishnaSSH Thanks for your patience. I'm new to a lot of this, so it took some time to sort things out. The conflict should be fixed now. |
Owner
|
Thanks for your work, No worries at all I appreciate your effort in sorting it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously requested this feature, but I have now removed all VLC fallback options since the project already includes mpv as a dependency.
The app can now play both audio and video, and it continues to support downloading as before.
VLC is no longer required, and everything works smoothly using mpv.