fix(utxo): fix header deserialization; guard AuxPoW by shamardy · Pull Request #2583 · GLEECBTC/komodo-defi-framework

shamardy · 2025-08-08T13:25:07Z

Should close #2048 when complete

…AV regression test

cipig

thanks for the fix
all coins from #2048 now work fine
and tested almost 50 others, just to be sure

…me_past`

- “UnexpectedEnd” without context can be misleading; including coin and the raw hex helps quickly pinpoint issues and not confuse it with a block header deserialization problem

onur-ozkan · 2025-08-09T11:03:00Z

Should this also resolve #2584?

shamardy · 2025-08-09T11:31:08Z

Should this also resolve #2584?

No, this is only for block headers. It did add better logging to get more info such as the info we have here now #2584 (comment)

mariocynicys

LGTM!
Thanks

mariocynicys · 2025-08-10T16:07:35Z

-                    let headers = reader.read_list::<BlockHeader>()?;
+
+                    let headers = reader.read_list::<BlockHeader>().map_to_mm(|e| UtxoRpcError::InvalidResponse(format!(
+                            "blockchain.block.headers: failed to parse list of {} headers (coin={}, from={}, requested_count={}): {}",


im confused why clippy complains sometimes about format arguments not being inlined into the string and sometimes it's ok with it :/

Same here 😅

* dev: fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583)

* dev: fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) # Conflicts: # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563)

* dev: (24 commits) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: improvement(`static mut`s): `static mut` removal (#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (#2597) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) chore(release): v2.3.0-beta (#2284) # Conflicts: # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: (28 commits) fix build script failing to find .git/HEAD (GLEECBTC#2601) refactor(EVM): rename fn, fix timeouts, add activation req validation (GLEECBTC#2543) improvement(`static mut`s): `static mut` removal (GLEECBTC#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (GLEECBTC#2597) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (GLEECBTC#2580) fix(clippy): fix clippy warnings for GLEECBTC#2565 (GLEECBTC#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (GLEECBTC#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (GLEECBTC#2564) feat(protocol): [0] solana support (GLEECBTC#2586) fix(utxo): fix header deserialization; guard AuxPoW (GLEECBTC#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (GLEECBTC#2581) fix(utxo): deserialize sapling root for PIVX block headers (GLEECBTC#2572) improvement(dep-stack): security bumps (GLEECBTC#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (GLEECBTC#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (GLEECBTC#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (GLEECBTC#2454) ci(pull-requests): review notification bot (GLEECBTC#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (GLEECBTC#2538) bless clippy (GLEECBTC#2560) refactor(toolchain): use latest available stable compiler (GLEECBTC#2557) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_rpc.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/lightning.rs # mm2src/coins/lp_coins.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/coins/siacoin.rs # mm2src/coins/tendermint/tendermint_token.rs # mm2src/coins/test_coin.rs # mm2src/coins/utxo/bch.rs # mm2src/coins/utxo/qtum.rs # mm2src/coins/utxo/slp.rs # mm2src/coins/utxo/utxo_standard.rs # mm2src/coins/z_coin.rs # mm2src/coins_activation/src/bch_with_tokens_activation.rs # mm2src/coins_activation/src/erc20_token_activation.rs # mm2src/coins_activation/src/eth_with_token_activation.rs # mm2src/coins_activation/src/init_erc20_token_activation.rs # mm2src/coins_activation/src/init_token.rs # mm2src/coins_activation/src/platform_coin_with_tokens.rs # mm2src/coins_activation/src/slp_token_activation.rs # mm2src/coins_activation/src/tendermint_with_assets_activation.rs # mm2src/coins_activation/src/token.rs # mm2src/mm2_main/src/lp_swap.rs # mm2src/mm2_main/src/lp_swap/check_balance.rs # mm2src/mm2_main/src/lp_swap/maker_swap.rs # mm2src/mm2_main/src/lp_swap/max_maker_vol_rpc.rs # mm2src/mm2_main/src/lp_swap/swap_v2_rpcs.rs # mm2src/mm2_main/src/lp_swap/taker_swap.rs # mm2src/mm2_main/src/lp_swap/trade_preimage.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/legacy.rs # mm2src/mm2_main/src/rpc/lp_commands/lr_swap.rs # mm2src/mm2_main/src/rpc/lp_commands/lr_swap/lr_impl.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/errors.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/docker_tests_common.rs # mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs # mm2src/mm2_main/tests/integration_tests_common/mod.rs # mm2src/trading_api/src/one_inch_api/client.rs

- Map forks for correct header parsing: - BTC: BTC/BCH/NAV/RIC - Qtum: QTUM/RUNES - PIVX: PIVX/DOGEC - RVN/KawPoW: RVN/AIPG/XNA/EVR/MEWC/AVN - Stop false AuxPoW parsing on BTC-like variants. - Improve deserialization errors with coin/hex context; add NAV v7 header test. Closes #2048 Refs #2584

shamardy added 5 commits August 8, 2025 16:23

serialization/reader: map RVN forks to CoinVariant::RVN (KawPoW headers)

6f0961b

stop false AuxPoW parsing on BTC-like forks; map NAV as BTC and add N…

53d7bd2

…AV regression test

treat RUNES (Runebase) as a Qtum fork to fix header deserialization

0d97824

treat DOGEC as a PIVX fork

c60b974

treat RIC as a BTC fork

2dc4a19

shamardy marked this pull request as ready for review August 9, 2025 00:05

shamardy requested a review from cipig August 9, 2025 00:05

treat AVN as a RVN fork

ac75ee8

cipig approved these changes Aug 9, 2025

View reviewed changes

add context to header parse errors in electrum clients `get_median_ti…

a63e413

…me_past`

shamardy requested a review from mariocynicys August 9, 2025 03:28

add coin/hex context to tx deserialize errors in tx_enum_from_bytes

3cd8ca1

- “UnexpectedEnd” without context can be misleading; including coin and the raw hex helps quickly pinpoint issues and not confuse it with a block header deserialization problem

cipig mentioned this pull request Aug 9, 2025

add coin ticker in error messages on seed nodes #2577

Closed

include coin/hex (and hash when available) in tx deserialization errors

b65af6f

cipig mentioned this pull request Aug 9, 2025

transaction deserialization errors #2584

Open

mariocynicys added the status: pending review label Aug 10, 2025

mariocynicys previously approved these changes Aug 10, 2025

View reviewed changes

fix 3 dots nit

38e8918

shamardy dismissed mariocynicys’s stale review via 38e8918 August 11, 2025 22:38

shamardy changed the title ~~fix(utxo): correct deserialization for block headers of multiple chains~~ fix(utxo): fix header deserialization; guard AuxPoW Aug 12, 2025

shamardy merged commit 1d96f9a into dev Aug 12, 2025
19 of 25 checks passed

shamardy deleted the fix/unexpected-end-various-coins branch August 12, 2025 12:42

dimxy pushed a commit that referenced this pull request Aug 12, 2025

Merge branch 'dev' into lr-swap-wip-3

2c1eba2

* dev: fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583)

dimxy pushed a commit that referenced this pull request Aug 12, 2025

Merge branch 'dev' into lr-swap-wip-2

ca37f34

* dev: fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583)

shamardy mentioned this pull request Nov 25, 2025

chore(release): v2.6.0-beta #2696

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(utxo): fix header deserialization; guard AuxPoW#2583

fix(utxo): fix header deserialization; guard AuxPoW#2583
shamardy merged 10 commits intodevfrom
fix/unexpected-end-various-coins

shamardy commented Aug 8, 2025

Uh oh!

cipig left a comment

Uh oh!

onur-ozkan commented Aug 9, 2025

Uh oh!

shamardy commented Aug 9, 2025

Uh oh!

mariocynicys left a comment

Uh oh!

mariocynicys Aug 10, 2025

Uh oh!

shamardy Aug 11, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shamardy commented Aug 8, 2025

Uh oh!

cipig left a comment

Choose a reason for hiding this comment

Uh oh!

onur-ozkan commented Aug 9, 2025

Uh oh!

shamardy commented Aug 9, 2025

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

mariocynicys Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

shamardy Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants