Skip to content

Marmara with new netmagic#95

Closed
kolobus wants to merge 1 commit intoKomodoPlatform:devfrom
kolobus:dev
Closed

Marmara with new netmagic#95
kolobus wants to merge 1 commit intoKomodoPlatform:devfrom
kolobus:dev

Conversation

@kolobus
Copy link
Copy Markdown
Contributor

@kolobus kolobus commented Apr 5, 2020

No description provided.

@kolobus
Copy link
Copy Markdown
Contributor Author

kolobus commented Apr 5, 2020

@ca333

@kolobus kolobus requested review from ca333 and tonymorony April 5, 2020 13:50
@DeckerSU
Copy link
Copy Markdown
Contributor

DeckerSU commented Apr 5, 2020

Netmagic value "netmagic\":\"9b71c84c\" in this PR is wrong. Should be \"netmagic\":\"4cc8719b\" as it was in #62 . Don't need to change anything.

p.s. Iguana's addcoin method just using low endian for netmagic, so value in #62 was correct, bcz 4cc8719b it's a 0x9b71c84c as bytes sequence.

@kolobus kolobus closed this Apr 5, 2020
@kolobus kolobus mentioned this pull request Apr 5, 2020
Merged
@ca333
Copy link
Copy Markdown
Contributor

ca333 commented Apr 5, 2020

Netmagic value "netmagic\":\"9b71c84c\" in this PR is wrong. Should be \"netmagic\":\"4cc8719b\" as it was in #62 . Don't need to change anything.

p.s. Iguana's addcoin method just using low endian for netmagic, so value in #62 was correct, bcz 4cc8719b it's a 0x9b71c84c as bytes sequence.

was referring to his previous PR and mixed up the comments.

cc: @kolobus

@kolobus
Copy link
Copy Markdown
Contributor Author

kolobus commented Apr 5, 2020

Mixed them, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants