Skip to content

Season 8#563

Merged
smk762 merged 41 commits intodevfrom
update/s8-pubkeys
Oct 5, 2024
Merged

Season 8#563
smk762 merged 41 commits intodevfrom
update/s8-pubkeys

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Aug 8, 2024 •
edited
Loading

@smk762 smk762 changed the base branch from master to dev August 8, 2024 10:03
onur-ozkan
onur-ozkan reviewed Aug 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos in my name

smk762 and others added 2 commits August 8, 2024 20:28
@smk762 @onur-ozkan
fix Onur name in 3p
d134631 
Co-authored-by: Onur Özkan <onurozkan.dev@outlook.com>
@smk762 @onur-ozkan
fix Onur name in main
164d7a8 
Co-authored-by: Onur Özkan <onurozkan.dev@outlook.com>
@smk762 smk762 mentioned this pull request Aug 8, 2024
Merged
shamardy
shamardy previously approved these changes Aug 8, 2024
View reviewed changes
@DeckerSU
Copy link
Copy Markdown
Contributor

DeckerSU commented Aug 12, 2024

I've fixed the core_DEV pubkeys; the keys for the mainnet and 3p nodes were mistakenly swapped. After my last commit, they are now correct. Additionally, we need to change 13348/tcp for the mainnet and 13345/tcp for 3p before the new season starts to separate the networks. We always begin a new season with new ports.

gcharang
gcharang previously approved these changes Oct 4, 2024
View reviewed changes
ca333
ca333 previously approved these changes Oct 4, 2024
View reviewed changes
DeckerSU
DeckerSU previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the things that I outlined in Element.

@smk762 smk762 dismissed stale reviews from DeckerSU, ca333, and gcharang via 92f5c9d October 5, 2024 04:54
@DeckerSU DeckerSU self-requested a review October 5, 2024 17:16
DeckerSU
DeckerSU approved these changes Oct 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@smk762 smk762 merged commit 2b55011 into dev Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ca333 ca333 ca333 left review comments

@Alrighttt Alrighttt Awaiting requested review from Alrighttt

+8 more reviewers

@onur-ozkan onur-ozkan onur-ozkan left review comments

@naezith naezith naezith approved these changes

@takenagain takenagain takenagain approved these changes

@dimxy dimxy dimxy approved these changes

@DeckerSU DeckerSU DeckerSU approved these changes

@cipig cipig cipig approved these changes

@gcharang gcharang gcharang left review comments

@shamardy shamardy shamardy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

under review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@smk762 @DeckerSU @naezith @ca333 @takenagain @dimxy @gcharang @cipig @shamardy @onur-ozkan