Skip to content

update AYA#217

Merged
ca333 merged 7 commits intomasterfrom
dev
Oct 31, 2020
Merged

update AYA#217
ca333 merged 7 commits intomasterfrom
dev

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Oct 31, 2020

No description provided.

Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also did a fast code review of AYA changes, checkBlacklist is unoptimal is some places (for example, we shouldn't fill addylist vector inside a indestination loop, we could do it earlier and not in loop), but seems should work.

@TheComputerGenie
Copy link
Copy Markdown
Contributor

TheComputerGenie commented Oct 31, 2020

Why is KomodoPlatform doing tx banning on some other chain and taking over the codebase?

@DeckerSU
Copy link
Copy Markdown
Contributor

Why is KomodoPlatform doing tx banning on some other chain and taking over the codebase?

It's not KomodoPlatform changes, it's coin founders changes. What about repo moving to KomodoPlatform, i guess the sources which should be deployed on NN - should be under KomodoPlatform control, to prevent malicious changes, so, it's for security purposes.

updates AYA build instructions
@ca333 ca333 merged commit 3187aa8 into master Oct 31, 2020
@TheComputerGenie
Copy link
Copy Markdown
Contributor

i guess the sources which should be deployed on NN - should be under KomodoPlatform control, to prevent malicious changes, so, it's for security purposes.

So, the logical next question would be: "When are you moving CHIPS, MCL, Einsteinium, and Verus over under the same concept?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants