Possible fix to avoid infinite loop (in rare cases) after PR 186#202
Merged
ca333 merged 3 commits intoKomodoPlatform:devfrom Oct 7, 2020
Merged
Possible fix to avoid infinite loop (in rare cases) after PR 186#202ca333 merged 3 commits intoKomodoPlatform:devfrom
ca333 merged 3 commits intoKomodoPlatform:devfrom
Conversation
Contributor
Author
|
@ca333 I should have target dev branch and not master, sorry. |
DeckerSU
approved these changes
Sep 17, 2020
ca333
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j was incremented at the beginning of the loop and in PR 186, I moved it to the end of the loop to be sure to take into account j = 0 but I forgot to take into account two cases with continue;
https://github.com/KomodoPlatform/dPoW/pull/186/files
I think that this new change fixes this problem. To be tested, discussed, analysed, code reviewed and merged.