Fix/command deprecation#210
Merged
nicolasmure merged 2 commits intomasterfrom Jun 6, 2019
Merged
Conversation
a74d09d to
7c5453c
Compare
7c5453c to
ba4ecb1
Compare
akerouanton
approved these changes
Jun 6, 2019
After upgrading to symfony 4.2 getting this deprecation error
` 1x: The "Knp\Bundle\GaufretteBundle\Command\FilesystemKeysCommand" class extends "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is deprecated since Symfony 4.2, use {@see Command} instead.`
changing to use "Symfony\Component\Console\Command\Command" fixes this issue
ba4ecb1 to
5587855
Compare
This was referenced Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #209 .
As @timgregg pointed out, the SF 4.2 have a deprecation on the
ContainerAwareCommandclass, and the services used in a command should be injected as dependencies.This PR completes the work of #209 by injecting the dependency.
TODO
FilesystemMapInterface