Skip to content

Test enhancement#627

Merged
nm2107 merged 1 commit intoKnpLabs:masterfrom
open-source-contributions:test_enhancement
Oct 24, 2019
Merged

Test enhancement#627
nm2107 merged 1 commit intoKnpLabs:masterfrom
open-source-contributions:test_enhancement

Conversation

@peter279k
Copy link
Copy Markdown
Contributor

Changed log

  • According to the PHPUnit fixtures reference, the setUp and tearDown methods should be protected, not public.
  • There're two approaches to mark test method on PHPUnit tests.
    One is method name with test prefix. and another one is using @test comment annotation on specific method name.
    To be consistency, let these methods be used with prefix.

Copy link
Copy Markdown
Contributor

@nm2107 nm2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ;)

@peter279k
Copy link
Copy Markdown
Contributor Author

thank you ;)

Thanks for your typo fix :).

Copy link
Copy Markdown
Contributor

@nm2107 nm2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ;)

@nm2107 nm2107 merged commit 2216a72 into KnpLabs:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants