Change Filesystem to FilesystemInterface in File#608
Merged
nicolasmure merged 1 commit intoKnpLabs:masterfrom Jun 6, 2019
athlan:patch-1
Merged
Change Filesystem to FilesystemInterface in File#608nicolasmure merged 1 commit intoKnpLabs:masterfrom athlan:patch-1
nicolasmure merged 1 commit intoKnpLabs:masterfrom
athlan:patch-1
Conversation
To extend functionality of Gaufrette to support `ResolvableFilesystem`, signature change is proposed to `FilesystemInterface`
akerouanton
approved these changes
Jun 5, 2019
Contributor
Author
|
Thanks a lot for approve. Any chance to merge and release soon? |
Contributor
|
Thank you @athlan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To extend functionality of Gaufrette to support
ResolvableFilesystem, signature change is proposed toFilesystemInterface.In some implementations there's File already provided and it could be resolved by filesystem. Now its not possible to use one filesystem to store files and resolve files because of aforementioned signature.