Skip to content

Fixing GridFS metadata bug where no metadata array returned#602

Closed
bsperduto wants to merge 1 commit intoKnpLabs:masterfrom
bsperduto:rel/gridfs-metadata-error-fix
Closed

Fixing GridFS metadata bug where no metadata array returned#602
bsperduto wants to merge 1 commit intoKnpLabs:masterfrom
bsperduto:rel/gridfs-metadata-error-fix

Conversation

@bsperduto
Copy link
Copy Markdown
Contributor

Fixing a gridfs adapter bug where the object exists but it does not contain a metadata array.

@nicolasmure
Copy link
Copy Markdown
Contributor

Hello @bsperduto :)
Thank you for your contribution ! Do you mind to write a spec covering this case ?

@bsperduto bsperduto force-pushed the rel/gridfs-metadata-error-fix branch from 8264570 to 0b37da1 Compare February 3, 2019 23:14
@bsperduto
Copy link
Copy Markdown
Contributor Author

Hello @bsperduto :)
Thank you for your contribution ! Do you mind to write a spec covering this case ?

Added a phpunit test to cover it. Gaufrette always creates the metadata object but when an outside library creates the gridfs file it doesn't always exist. This should cover that situation.

@nicolasmure
Copy link
Copy Markdown
Contributor

Replaced by #609 (cherry-picked)

@nicolasmure nicolasmure closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants