Merged
Conversation
akerouanton
reviewed
Dec 10, 2018
.travis.yml
Outdated
| @@ -30,6 +30,7 @@ matrix: | |||
| - php: '7.0' | |||
Contributor
There was a problem hiding this comment.
I think we should also drop support for PHP 5.6 and 7.0, as 7.0 has been EOL'ed and 5.6 will be at the end of the year.
5f96dfc to
43835f7
Compare
Also bump phpunit to v7 and phpspec to v5
43835f7 to
154cc1c
Compare
154cc1c to
b54a01e
Compare
Closed
Contributor
|
Is a new release planned with these fixes? |
Contributor
Author
|
Yes it is (see #597), we'll try to also make a new release of the bundle. |
Contributor
|
Nice, thank you very much @nicolasmure |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cherry-picked the commit from #587 cc/ @andreybolonin
Fixes #592 .