Skip to content

Fix ini_get() for boolean values#588

Closed
deguif wants to merge 1 commit intoKnpLabs:masterfrom
deguif:master
Closed

Fix ini_get() for boolean values#588
deguif wants to merge 1 commit intoKnpLabs:masterfrom
deguif:master

Conversation

@deguif
Copy link
Copy Markdown
Contributor

@deguif deguif commented Oct 31, 2018

Currently setting false or off, ... value to configure some PHP ini directives will make this evaluated to true as this is equal to a non empty string.

@nicolasmure
Copy link
Copy Markdown
Contributor

Hello @deguif :)

Thank you for your contribution ! Do you mind to rebase your work on the master branch now that the appveyor build has been fixed ?

@nicolasmure
Copy link
Copy Markdown
Contributor

I cherry-picked the commit into #595. Thank you @deguif !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants