Add support for major release of Azure Blob Storage SDK#558
Merged
nicolasmure merged 1 commit intoKnpLabs:masterfrom Mar 26, 2018
Merged
Add support for major release of Azure Blob Storage SDK#558nicolasmure merged 1 commit intoKnpLabs:masterfrom
nicolasmure merged 1 commit intoKnpLabs:masterfrom
Conversation
Contributor
|
Hello, thank you for your PR. Can you add some comments in the code indicating that some class usage is for Moreover, can you rebase your branch on the master branch now that the appveyor build has been fixed ? |
Contributor
Author
|
Thank you for your review. The PR has been rebased and I improved the documentation a bit. |
2 tasks
akerouanton
approved these changes
Mar 26, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK for Azure Storage was recently split up in 4 separate packages. Now, it's recommended to use
microsoft/azure-storage-blobfor handling blobs.This patch extends the adapter to support the new SDK as well (in a backwards-compatible way). The functional tests pass with both versions.