Skip to content

♻️ Do not use the deprecated method parameter in FileResponse inside of StaticFiles#2406

Merged
Kludex merged 3 commits intoKludex:masterfrom
tiangolo:static-files-file-response
Jan 11, 2024
Merged

♻️ Do not use the deprecated method parameter in FileResponse inside of StaticFiles#2406
Kludex merged 3 commits intoKludex:masterfrom
tiangolo:static-files-file-response

Conversation

@tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Jan 11, 2024

Summary

♻️ Do not use the deprecated method parameter in FileResponse inside of StaticFiles

This is a continuation of #2366

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Owner

Kludex commented Jan 11, 2024

I saw this the other day... I thought I had included this somewhere. 🤔

Thanks. 👍

@tiangolo tiangolo marked this pull request as ready for review January 11, 2024 15:13
@tiangolo tiangolo requested a review from Kludex January 11, 2024 15:13
@tiangolo tiangolo changed the title ♻️ Do not use the deprecated method parameter in FileResponse inside of StaticFiles ♻️ Do not use the deprecated method parameter in FileResponse inside of StaticFiles Jan 11, 2024
@Kludex Kludex merged commit 3734e85 into Kludex:master Jan 11, 2024
@tiangolo tiangolo deleted the static-files-file-response branch January 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants