Conversation
Kludex
commented
Nov 28, 2023
| else: | ||
| self.lifespan_context = lifespan | ||
|
|
||
| self.middleware_stack = self.app |
Owner
Author
There was a problem hiding this comment.
I know you'll comment about the names, but I prefer them.
iudeen
approved these changes
Dec 1, 2023
Contributor
iudeen
left a comment
There was a problem hiding this comment.
Looks good.
Do we need to update docs?
de102eb to
11d5b8c
Compare
Owner
Author
|
@encode/maintainers someone else wants to review this? |
abersheeran
reviewed
Dec 1, 2023
| # which the router cannot know statically, so we use typing.Any | ||
| lifespan: typing.Optional[Lifespan[typing.Any]] = None, | ||
| *, | ||
| middleware: typing.Optional[typing.Sequence[Middleware]] = None, |
Contributor
There was a problem hiding this comment.
Maybe use name middlewares?
Owner
Author
There was a problem hiding this comment.
But we use middleware everywhere already...
Contributor
There was a problem hiding this comment.
😂 Oh, I didn't even notice that.
abersheeran
approved these changes
Dec 1, 2023
Contributor
abersheeran
left a comment
There was a problem hiding this comment.
Simple and elegant modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.