Don't group duplicated headers on a single string on the TestClient #2219
Merged
Kludex merged 4 commits intoKludex:masterfrom Jul 23, 2023
Merged
Don't group duplicated headers on a single string on the TestClient #2219Kludex merged 4 commits intoKludex:masterfrom
TestClient #2219Kludex merged 4 commits intoKludex:masterfrom
Conversation
Kludex
reviewed
Jul 22, 2023
Contributor
Author
|
i found multi_items method that lower case key. |
TestClient
Kludex
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The testclient handles headers with duplicate field names differently.
when request with headers with duplicate field name, starlette can handles like this
starlette
but testclient(httpx client) not handles like that
testclient
so i fixed the testclient same as starlette to handle headers with duplicate field name
Checklist