Remove converter from path when generating OpenAPI schema#1648
Merged
Remove converter from path when generating OpenAPI schema#1648
OpenAPI schema#1648Conversation
Kludex
commented
May 24, 2022
| @@ -49,10 +50,11 @@ def get_endpoints( | |||
|
|
|||
| for route in routes: | |||
Owner
Author
There was a problem hiding this comment.
route may not have path attribute, that's why the path =... is not here.
|
Hi, thank you for fixing this so quickly. Just a quick question: Why not put it into the next bug fix release e.g. 0.20.4 instead 0.21? Unfortunately I am a bit stuck continuing my code until this is fixed. |
Owner
Author
Yeah, it can be on 0.20.4. |
lovelydinosaur
approved these changes
Jun 27, 2022
Contributor
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks good, yup. One suggestion, but not a blocker.
Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be more correct, I'd have to add the information about the type of the path parameter...