Secret: add a __bool__ implementation by rcoup · Pull Request #1625 · Kludex/starlette

rcoup · 2022-05-05T12:29:41Z

Allows using a Secrets in a conditional statement to check for empty/None without needing to cast it to a str.

Before:

if str(settings.A_SECRET):  # without the cast it's always True
  # do stuff

After:

if settings.A_SECRET:
  # do stuff

Allows using `if settings.A_SECRET:` to check for empty/None without needing to cast it to a str.

Kludex · 2022-05-05T22:01:15Z

Thanks for the PR @rcoup !

Secret: add a __bool__ implementation

9af5116

Allows using `if settings.A_SECRET:` to check for empty/None without needing to cast it to a str.

Kludex added the feature New feature or request label May 5, 2022

Kludex approved these changes May 5, 2022

View reviewed changes

Kludex merged commit beb8943 into Kludex:master May 5, 2022

rcoup deleted the rc-secret-bool branch May 6, 2022 08:29

Provide feedback