Deprecate WS_1004_NO_STATUS_RCVD and WS_1005_ABNORMAL_CLOSURE#1580
Merged
Deprecate WS_1004_NO_STATUS_RCVD and WS_1005_ABNORMAL_CLOSURE#1580
WS_1004_NO_STATUS_RCVD and WS_1005_ABNORMAL_CLOSURE#1580Conversation
Owner
Author
I didn't say that, at least I didn't mean it. I mean that we should fix it before stop supporting Python 3.6, so at least the last version has it right. |
Contributor
|
So the idea here is to cut 1 release with those code then immediately remove it right? So:
Am I getting this right? |
Owner
Author
|
Yes. |
Owner
Author
|
The backport removal will be on the PR that drops Python 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1578
This PR has the same idea as django/asgiref#272.
The idea here is to deprecate two constants using the PEP 562. Unfortunately I need to use a backport for Python 3.6 - but I guess we'd want to release this for Python 3.6 before removing the Python 3.6 support.
NOTE: After this PR gets in, a patch release is needed.