Skip to content

Avoid TypeError on websocket.disconnect when code is None#1574

Merged
Kludex merged 2 commits intomasterfrom
fix/close-code-websocket-endpoint
Apr 6, 2022
Merged

Avoid TypeError on websocket.disconnect when code is None#1574
Kludex merged 2 commits intomasterfrom
fix/close-code-websocket-endpoint

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Apr 5, 2022

Closes #1560

@Kludex Kludex requested a review from a team April 5, 2022 19:01
@Kludex Kludex changed the title Default to 1000 in case of code being None on websocket.disconnect Avoid TypeError on websocket.disconnect when code is None Apr 5, 2022
@Kludex Kludex merged commit 487f05d into master Apr 6, 2022
@Kludex Kludex deleted the fix/close-code-websocket-endpoint branch April 6, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Denying WebSocket connection in WebSocketEndpoint.on_connect leads to Exception

2 participants