Merged
Conversation
Kludex
requested changes
Dec 28, 2021
Owner
Kludex
left a comment
There was a problem hiding this comment.
max_age type on the __init__ should be Optional[int] as it can receive None now.
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
reviewed
Jan 12, 2022
| set_cookie = response.headers["set-cookie"] | ||
| assert "Max-Age" not in set_cookie | ||
|
|
||
| client.cookies.clear_session_cookies() |
Owner
There was a problem hiding this comment.
Note to myself: use client.cookies.clear instead of client.cookies.clear_session_cookies on #1376
Contributor
Author
There was a problem hiding this comment.
why? afaik this method will keep all other cookies except session-scoped.
Owner
There was a problem hiding this comment.
Oh right, yeah... httpx doesn't have clear_session_cookies 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of SessionMiddleware.
If the user sets
max_ageto None or 0 then a cookie will be Session-only and will be destroyed after closing the browser.