Raise a more obvious exception when form data is missing "boundary".#1349
Merged
lovelydinosaur merged 6 commits intoKludex:masterfrom Feb 3, 2022
toxadx:master
Merged
Raise a more obvious exception when form data is missing "boundary".#1349lovelydinosaur merged 6 commits intoKludex:masterfrom toxadx:master
lovelydinosaur merged 6 commits intoKludex:masterfrom
toxadx:master
Conversation
lovelydinosaur
approved these changes
Feb 3, 2022
Contributor
lovelydinosaur
left a comment
There was a problem hiding this comment.
Raising a KeyError here isn't perfect, but I'd agree that it's better.
So yup, let's go with this. Thanks!
Owner
|
We should probably catch that and raise something else from Starlette itself 🤔 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The best strategy is to let KeyError raise when parsing request with missing boundary parameter, so end-user can process KeyError exception in their code.
Closes #1125
Related to #1303