Add union operators to MutableHeaders#1240
Merged
lovelydinosaur merged 6 commits intoKludex:masterfrom Feb 16, 2022
manlix:headers_merge
Merged
Add union operators to MutableHeaders#1240lovelydinosaur merged 6 commits intoKludex:masterfrom manlix:headers_merge
lovelydinosaur merged 6 commits intoKludex:masterfrom
manlix:headers_merge
Conversation
jcwilson
reviewed
Jul 20, 2021
Kludex
previously requested changes
Jan 9, 2022
Owner
|
@manlix Are you still interested in this PR? If so, would you mind rebasing and checking my comment? |
Contributor
Author
|
@Kludex Thank you for your suggest. PR has been updated + new tests bundle. |
* Use `TypeError`, not `NotImplemented`. * Add `# type: ignore` to deliberate incorrect usage of types in tests.
lovelydinosaur
approved these changes
Feb 16, 2022
Contributor
lovelydinosaur
left a comment
There was a problem hiding this comment.
👍 - Great thanks!
Made some minor tweaks. (TypeError, not NotImplemented)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1239
Edit by @Kludex: Closes #1239