kinematics: Add hybrid-corexy and hybrid-corexz#4229
Conversation
KevinOConnor
left a comment
There was a problem hiding this comment.
Thanks. In general it looks good to me. I have a few comments below.
-Kevin
| # the z axis. The default is to use max_accel for max_z_accel. | ||
|
|
||
| # The stepper_x section is used to describe the X axis as well as the | ||
| # stepper controlling the X+Z movement. |
There was a problem hiding this comment.
Is this a typo? The code seems to use X-Y for this axis.
| [stepper_y] | ||
|
|
||
| # The stepper_z section is used to describe the Z axis as well as the | ||
| # stepper controlling the X-Z movement. |
| ## Hybrid-CoreXZ Kinematics | ||
|
|
||
| See [example-hybrid-corexz.cfg](../config/example-hybrid-corexz.cfg) | ||
| for an example hybrid corexz kinematics config file. |
There was a problem hiding this comment.
Do you have a hybrid-corexz printer that you've tested this on? If not, I think it would be preferable to add support when we have users of it.
There was a problem hiding this comment.
Thank you for yours comments.
I have a physical mockup which allows me to test all situations for the gantry.
Ankurv is running the (full) hybrid-corexz branch on his IDEX Switchwire and print with it.
As requested on my previous PR, I split the code into more manageable sections. This PR is the for a simple carriage printer but the complement will follow soon. Thanks to Ankurv to test all of these features for real.
| # Code for handling the kinematics of hybrid-corexy robots | ||
| # The hybrid-corexy kinematic is also known as Markforged kinematics |
There was a problem hiding this comment.
Please use a single line for the file description. It's preferable for all the code to have the same format file header: 1 line comment, 1 blank line, 1 line copyright, 1 blank line, 1 line license. You can, of course, add any amount of comment lines after the initial header block.
| @@ -0,0 +1,79 @@ | |||
| # This file is an example config file for hybrid corexy style printers also | |||
There was a problem hiding this comment.
When adding an "example-" config file, it's a good idea to also add it to test/klippy/printers.test regression test tool. See https://www.klipper3d.org/Example_Configs.html
Fix typo in Config_Reference.md Fix header in hybrid_corexy.py and hybrid_corexz.py Add example configs to printers.test
Follows commit 5a5ecd8
|
Thanks. -Kevin |
Add hybrid-corexy kinematics.
Add hybrid-corexz kinematics.
Both are simple carriage version of the kinematics also known as Markforged kinematics.
This follows the issue #3391 and is a revamp of pull request #3609
Signed-off-by: Fabrice GALLET tircown@gmail.com