XR Runtime Combobox Enhancements#157
Merged
jcfr merged 7 commits intoKitwareMedical:masterfrom Jan 11, 2024
Merged
Conversation
This change is done anticipating subsequent commit fixing the inilization and use of the default view node.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds enhancements to the "XR Runtime" combobox, including disabling the combobox if hardware is connected, saving and restoring the last XR runtime from settings and populating the combobox based on supported XR runtimes.
Additionally, the code has been refactored to introduce the
updateDefaultViewNodeFromSettings()function and simplify the logic by explicitly initializing theActiveViewNode.