COMP: Update OpenXR integration to rely on OpenXR config module#156
Merged
jcfr merged 1 commit intoKitwareMedical:masterfrom Jan 10, 2024
Merged
Conversation
Update build-system to rely on OpenXR config module instead of the custom FindOpenXR.cmake module provided by VTK. Update OpenXR library install rule to leverage the IMPORTED_RUNTIME_ARTIFACTS install command mode introduced in CMake 3.21. See https://cmake.org/cmake/help/v3.21/command/install.html#imported-runtime-artifacts
8820922 to
9084562
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update build-system to rely on OpenXR config module instead of the custom FindOpenXR.cmake module provided by VTK.
Update OpenXR library install rule to leverage the
IMPORTED_RUNTIME_ARTIFACTSinstall command mode introduced in CMake 3.21.See https://cmake.org/cmake/help/v3.21/command/install.html#imported-runtime-artifacts
This depends on VTK changes backported through the following merge requests:
SlicerPreview:OpenXRConfig.cmakefile provided by OpenXR-SDK Slicer/VTK#51SlicerStable:OpenXRConfig.cmakefile provided by OpenXR-SDK Slicer/VTK#52Stablebuild tree oncomputron(macOS),metroplex(Linux) andoverload(Windows) build machines.Footnotes
https://github.com/Slicer/VTK/pull/52#issuecomment-1884224007 ↩