Add OpenXRRemoting support#151
Merged
jcfr merged 4 commits intoKitwareMedical:masterfrom Jan 11, 2024
Merged
Conversation
Collaborator
|
This will be awesome! Please also describe in the documentarion how to set up remote rendering using HoloLens (what to install, how to configure, how to start). |
e8e082d to
62fcb09
Compare
c591a63 to
bf5402e
Compare
Adds SlicerVirtualReality_HAS_OPENXRREMOTING_SUPPORT CMake option enabling the build of OpenXRRemoting and vtkRenderingOpenXRRemoting external projects.
This requires VTK MR-10449 (see [1]) backported to Slicer/VTK through the Slicer PR-7190 (see [2]). [1] https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10449 [2] Slicer/Slicer#7190 (cherry picked from commit KitwareMedical/SlicerMixedReality@5d5db0b)
This commit updates the view node by adding "Remoting" and "PlayerIPAddress" properties. The corresponding UI updates include a checkbox for toggling remoting and a `QLineEdit` for entering the IP address. The macro `SlicerVirtualReality_HAS_OPENXRREMOTING_SUPPORT` is added to `vtkMRMLVirtualRealityConfigure.h.in` to conditionally include code specific to OpenXR remoting. The "Remoting" checkbox and "PlayerIPAddress" line edit are disabled if an active connection has been established. To fix OpenXRRemoting "wglDXRegisterObjectNV failed in RegisterSharedTexture()", the OpenXRRemoting HelperWindow MultiSamples property is explicitly set to 0. To ensure no background is displayed, the background alpha/color/gradient is explicitly set when remoting is used. The last "Remoting" and "PlayerIPAddress" properties associated with a successful hardware connection are saved to and restored from the settings. Co-authored-by: Lucas Gandel <lucas.gandel@kitware.com>
a86d1a7 to
9f02ed2
Compare
3 tasks
This enhancement enables building the SlicerVirtualReality extension against the latest version (2.9.3) of Microsoft.Holographic.Remoting.OpenXr. This aligns SlicerVirtualReality with the corresponding version of the "Holographic Remoting Player" available on the Microsoft Store. The update relies on VTK changes integrated into the upstream VTK project via vtk/vtk!10814. Additionally, Slicer/VTK fork branches, namely Slicer/VTK#53 for SlicerPreview and Slicer/VTK#54 for SlicerStable, have been synchronized with these changes. For SlicerPreview, changes have been integrated in Slicer through Slicer/Slicer#7534. In the case of SlicerStable, the updated VTK fork has been manually checked out on the relevant build machines to incorporate the necessary adjustments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for OpenXR Remoting by adding the
OpenXRRemotingandvtkRenderingOpenXRRemotingexternal projects. It also updates the view node by adding "Remoting" and "PlayerIPAddress" properties. The corresponding UI updates include a checkbox for toggling remoting and aQLineEditfor entering the IP address.The macro
SlicerVirtualReality_HAS_OPENXRREMOTING_SUPPORTis added tovtkMRMLVirtualRealityConfigure.h.into conditionally include code specific to OpenXR remoting.The "Remoting" checkbox and "PlayerIPAddress" line edit are disabled if an active connection has been established.
To fix the issue of
wglDXRegisterObjectNV failed in RegisterSharedTexture()in OpenXRRemoting, the OpenXRRemoting HelperWindow MultiSamples property is explicitly set to 0.To ensure that no background is displayed, the background alpha/color/gradient is explicitly set when remoting is used.
The last "Remoting" and "PlayerIPAddress" properties associated with a successful hardware connection are saved to and restored from the settings.
Update OpenXRRemoting from 2.9.1 to 2.9.3: This enables building the SlicerVirtualReality extension against the latest version (2.9.3) of Microsoft.Holographic.Remoting.OpenXr. This aligns SlicerVirtualReality with the corresponding version of the "Holographic Remoting Player" available on the Microsoft Store.
The update relies on VTK changes integrated into the upstream VTK project via vtk/vtk!10814. Additionally, Slicer/VTK fork branches, namely Slicer/VTK#53 for SlicerPreview and Slicer/VTK#54 for SlicerStable, have been synchronized with these changes.
For SlicerPreview, changes have been integrated in Slicer through Slicer/Slicer#7534. In the case of SlicerStable, the updated VTK fork has been manually checked out on the relevant build machines to incorporate the necessary adjustments.