BUG: Fix lookup of manifest file from build tree#120
Merged
jcfr merged 1 commit intoKitwareMedical:masterfrom Aug 26, 2023
Merged
Conversation
Remove the "externals" sub-directory that was specific to branch Slicer/VTK@slicer-v9.1.20220125-efbe2afc2 integrating commit Slicer/VTK@0ba7af630 ([Backport MR-8123] vtk_module_build: Ensure external modules build directory are not overwritten) Since the approach originally proposed in VTK MR-8123 was superseded by MR-9097 there is no need to specify the "externals" sub-directory.
Contributor
Author
|
Related to: |
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the "externals" sub-directory that was specific to branch Slicer/VTK@slicer-v9.1.20220125-efbe2afc2 integrating commit Slicer/VTK@0ba7af630 (
[Backport MR-8123] vtk_module_build: Ensure external modules build directory are not overwritten)Since the approach originally proposed in VTK MR-8123 was superseded by MR-9097 there is no need to specify the "externals" sub-directory.