COMP: Fix build accounting for vtkVirtualRealityViewInteractor API change#119
Merged
jcfr merged 1 commit intoKitwareMedical:masterfrom Jul 15, 2023
Conversation
…ange This commit renames the function from HandleGripEvents to HandleComplexGestureEvents to account for the change introduced through VTK MR-9892. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9892 It fixes error like the following: In file included from /path/to/SlicerVirtualReality/VirtualReality/MRML/vtkVirtualRealityViewInteractor.cxx:21: /path/to/SlicerVirtualReality/VirtualReality/MRML/vtkVirtualRealityViewInteractor.h:49:16: error: ‘virtual void vtkVirtualRealityViewInteractor::HandleGripEvents(vtkEventData*)’ marked ‘override’, but does not override 49 | virtual void HandleGripEvents(vtkEventData* ed) override; | ^~~~~~~~~~~~~~~~
0fa502e to
2b0050e
Compare
Contributor
Author
|
Since this change is not backward compatible:
In the meantime, I will integrate |
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames the function from
HandleGripEventstoHandleComplexGestureEventsto account for the change introduced through VTK MR-9892.See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9892
It fixes error like the following: