Fix lookup of manifest files from both install and build trees#117
Merged
jcfr merged 2 commits intoKitwareMedical:masterfrom Jun 15, 2023
Merged
Fix lookup of manifest files from both install and build trees#117jcfr merged 2 commits intoKitwareMedical:masterfrom
jcfr merged 2 commits intoKitwareMedical:masterfrom
Conversation
Contributor
Author
|
After testing locally, lookup of manifest files:
After inspecting the content of the extension package, the manifest files are not in the
|
Collaborator
|
Thanks a lot @jcfr for working on this! Feel free to merge it, as it solves half the issues. I don't have an idea off the bat why it does not work... |
This comment was marked as outdated.
This comment was marked as outdated.
This commit is a follow-up of dec1acf (BUG: Ensure action manifest files are found during interctor initialization) and 08485bd (BUG: Improve action manifest paths) It implements the following changes: 1. Append the "/" character required to successfully compose the full manifest file path. Indeed, in vtkOpenVRRenderWindowInteractor::Initialize() the directory and filename are joined using "this->ActionManifestDirectory + this->ActionManifestFileName" 2. Fix the manifest directory associated with: - the build by appending the "externals/vtkRenderingOpenVR" sub-directory. - the installed extension by ensuring the manifests are looked up in a known.
2865a2f to
6310ecc
Compare
Contributor
Author
|
Manifest files should now be properly looked up:
|
Contributor
Author
|
Today's package has been updated as well.
|
Collaborator
|
Thanks a lot for this fix! For non-developer users this is a must. |
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lookup of manifest file from install or build trees
This commit is a follow-up of dec1acf (
BUG: Ensure action manifest files are found during interctor initialization) and 08485bd (BUG: Improve action manifest paths)It implements the following changes:
Append the
/character required to successfully compose the full manifest file path.Indeed, in
vtkOpenVRRenderWindowInteractor::Initialize()the directory and filename are joined usingthis->ActionManifestDirectory + this->ActionManifestFileNameFix the manifest directory associated with:
the build by appending the
externals/vtkRenderingOpenVRsub-directory.the installed extension by ensuring the manifests are looked up in a
known.