Enable bulk track selection for operations #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents multi track deletion from attempting to auto select a track that no longer exists because it was included in a bulk delete operation.
naglepuff
commented
Aug 19, 2025
BryonLewis
requested changes
Sep 2, 2025
Comment on lines
540
to
549
| </v-label> | ||
| <TypePicker | ||
| :value="multiTrackType" | ||
| :all-types="allGroupTypesRef" | ||
| :read-only-mode="readOnlyMode" | ||
| selected | ||
| update-on-input | ||
| data-list-source="allGroupTypesOptions" | ||
| @input="updateMultiTrackType" | ||
| /> |
Collaborator
There was a problem hiding this comment.
I think we should add the lock-types prop to this component from clientSettings. This is a functionaltiy that if in the Type List settings you can prevent users from entering in their own custom types. It changes the behavior of the TypePicker slightly so it is dropdown instead of a combo box and limits what types can be used.
Collaborator
Author
There was a problem hiding this comment.
d5d4e3a imports clientSettings and uses it for this component.
BryonLewis
requested changes
Sep 2, 2025
183caec to
84f2b78
Compare
Co-authored-by: Bryon Lewis <61746913+BryonLewis@users.noreply.github.com>
BryonLewis
requested changes
Sep 2, 2025
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
Minor change related to the TypePicker and locking types.
Co-authored-by: Bryon Lewis <61746913+BryonLewis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1504
Changes
Demo
Multi-select tracks: This video demonstrates ctrl+clicking on annotations, the event viewer, and the track list. It also contains examples of clicking outside of tracks to deselect them all, and ctrl+click on a selected track will deselect that track.
ctrl_click_demo.mp4
Changing types and deleting tracks:
multi_edit_delete.mp4
To-do