Skip to content

Conversation

@BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Apr 6, 2023

resolves #1329

Done:

  • Frame remapping when images are a subsample of those referenced in a loaded CSV file for electron
  • Updated client tests for new errors and formats
  • If images referenced in CSV include images in the dataset and they are in the proper order it will allow loading
  • Extra images are ignored then
  • Logic for this has been updated on Electron version as well as python version

Testing:

  • Take a sample dataset like Ehu from the server and copy and create 3 different folders. Ehu Link
    • The base dataset with all the images
    • A subsampled dataset with 20-30 sequential images
    • A subsampled dataset with 20-30 non-sequential images
  • Take the original annotations.csv file from Ehu and load it into the sequential images dataset. It should load and display annotations properly. The frame numbers will be different but it should load
  • Attempt to load the original into the non-sequential image dataset and an error should occur.
  • You can take a look at the viame.spec.ts file for the client version and the test_serialize_viame_csv.py for the python version and create some other sample CSVs and check that they import properly and give the proper errors.

@BryonLewis BryonLewis marked this pull request as ready for review April 7, 2023 13:12
@BryonLewis BryonLewis requested a review from marySalvi April 7, 2023 13:17
Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Followed the testing steps provided and everything worked as expected. This is very cool btw.

@BryonLewis BryonLewis merged commit f1b9c03 into main Apr 17, 2023
@BryonLewis BryonLewis deleted the subsample-import branch April 17, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not error out when loading a subset of images from those contained in a CSV

2 participants