Skip to content

Conversation

@BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Jan 30, 2023

This relates to this PR girder/girder#3434 on Girder and Grunt version pinning.

This PR became a bit more involved:

  • Updated Poetry to latest (1.3.2) because poetry lock files are version dependent and to make dev easier this was done
  • Updated girder and girder_jobs to 3.1.16 to fix the Grunt build issue
  • This caused an issue where docker couldn't build the container unless girder_worker was also updated so that was updated to the latest version.
  • There were some changes in girder_worker which needed to be resolved
    • The worker initialization needed to have a default value 'worker' added to the system. This is the same as in the girder_worker plugin
    • We were previously adding a queue count to the 'job' endpoint and just so happened that the plugin order was allowing us to do this before. I've updated it so that now it manually ensures that the jobs plugin is loaded before adding that additional endpoint.

waxlamp
waxlamp previously approved these changes Jan 30, 2023
@BryonLewis BryonLewis merged commit 9af0070 into main Jan 31, 2023
@BryonLewis BryonLewis deleted the update-girder branch January 31, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants