-
Notifications
You must be signed in to change notification settings - Fork 23
Additive import #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additive import #1309
Conversation
| <div v-if="additive"> | ||
| <v-text-field | ||
| v-model="additivePrepend" | ||
| label="Prepend to types" | ||
| clearable | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a tooltip or hint to explain the functionality of this prepend text
| <v-switch | ||
| v-model="additive" | ||
| label="Additive" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like additive isn't intuitive. Perhaps instead a checkbox with an 'overwrite' label defaulted to checked.
| import lockfile from 'proper-lockfile'; | ||
| import { | ||
| cloneDeep, merge, uniq, pick, | ||
| cloneDeep, merge, uniq, pick, add, max, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like add and max isn't used
|
I am completely open to any other wording or suggestions that you may have for it. I also looked through the code and it looks like I already implemented the Desktop version of this (It's been a branch for too long and I forgot 🤦 ) |
Heh I noticed that but I thought maybe it wasn't fully hooked up yet. I'll do a visual check on desktop, already checked the code. |
This is a PR that was an upstream branch for some other deployments. For right now these changes are in the Web Version only. I can make a separate PR to incorporate these changes into the electron version.
Creates an additive import option for
postprocess:additivemeans that if an annotation file is found during postprocess it will add the tracks to existing tracks instead of doing a replacement.additive_prependis a value that is prepended to all types of the new tracks found. This is to easily filter the tracks in the type editor between the new and old tracks.Code Changes:
I apologize for the commit history, if required I can squash it down. During the merge it will become squashed anyways.