-
Notifications
You must be signed in to change notification settings - Fork 23
Add TrackJSON Download and SkipTranscoding Options. #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What happens if you knowingly enable this option on a video that's not in the right format? (i.e., what kind of error message or error state will the user find themselves in?) |
Currently, it will fall back on transcoding the video. That is probably not desired when importing videos and having that option set. I can easily change it to create an error in the job log. |
|
Note to self: Clarify the setting as being "Attempt to Skip transcoding". It will fall back to transcoding if the video files are not in the proper format. Log this information in the Job log and update the UI elements to accurately indicate to the user this setting (may need to use a help icon tip for the longer explanation). |
marySalvi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, working well. Just minor grammar changes.
Co-authored-by: Mary Salvi <40494088+marySalvi@users.noreply.github.com>
Co-authored-by: Mary Salvi <40494088+marySalvi@users.noreply.github.com>
skipTranscodingparameter set to true. Should only be done by those who know that their video is h264 encoded.