Skip to content

Conversation

@BryonLewis
Copy link
Collaborator

  • Annotation download button modified within web version to have a dropdown to select the TrackJSON instead of always exporting the viame-csv format
  • Logic included preventing transcoding when uploaded with the skipTranscoding parameter set to true. Should only be done by those who know that their video is h264 encoded.

@waxlamp
Copy link
Member

waxlamp commented Sep 12, 2022

  • Logic included preventing transcoding when uploaded with the skipTranscoding parameter set to true. Should only be done by those who know that their video is h264 encoded.

What happens if you knowingly enable this option on a video that's not in the right format? (i.e., what kind of error message or error state will the user find themselves in?)

@BryonLewis
Copy link
Collaborator Author

  • Logic included preventing transcoding when uploaded with the skipTranscoding parameter set to true. Should only be done by those who know that their video is h264 encoded.

What happens if you knowingly enable this option on a video that's not in the right format? (i.e., what kind of error message or error state will the user find themselves in?)

Currently, it will fall back on transcoding the video. That is probably not desired when importing videos and having that option set. I can easily change it to create an error in the job log.

@BryonLewis
Copy link
Collaborator Author

Note to self: Clarify the setting as being "Attempt to Skip transcoding". It will fall back to transcoding if the video files are not in the proper format. Log this information in the Job log and update the UI elements to accurately indicate to the user this setting (may need to use a help icon tip for the longer explanation).

Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, working well. Just minor grammar changes.

BryonLewis and others added 2 commits September 21, 2022 07:46
Co-authored-by: Mary Salvi <40494088+marySalvi@users.noreply.github.com>
Co-authored-by: Mary Salvi <40494088+marySalvi@users.noreply.github.com>
marySalvi
marySalvi previously approved these changes Sep 21, 2022
@BryonLewis BryonLewis merged commit 0c55481 into main Sep 27, 2022
@BryonLewis BryonLewis deleted the briar-mods branch September 27, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants