Numeric Slider Support #1285
Numeric Slider Support #1285
Conversation
| /> | ||
| <div v-if="datatype=== 'number'"> | ||
| <v-radio-group | ||
| :value="editor.type" |
There was a problem hiding this comment.
I think this line is causing an error for existing attributes. When you click the edit attribute cog the dialog fails to load and console displays this:
There was a problem hiding this comment.
Yup, editor probably needs to be checked to see if it exists, editor can be undefined.
marySalvi
left a comment
There was a problem hiding this comment.
When changing a combobox with an existing value to a slider, the value is lost. Is that behavior we want or would we want the slider positioned at that previous value?
| outlined | ||
| :step="editor.range[1]> 1 ? 1 : 0.01" | ||
| type="number" | ||
| label="Upper" |
There was a problem hiding this comment.
I would change label to 'Max'
| outlined | ||
| :step="editor.range[0]> 1 ? 1 : 0.01" | ||
| type="number" | ||
| label="Lower" |
There was a problem hiding this comment.
I would change label to 'Min'
| outlined | ||
| :step="editor.steps> 1 ? 1 : 0.01" | ||
| type="number" | ||
| label="Slider Resolution" |
There was a problem hiding this comment.
In would change label to something like 'Slider Step Interval' and the hint to something like 'Slider will increase/decrease by this value'
| :step="typeSettings.steps ? typeSettings.steps | ||
| : (typeSettings.range[1] - typeSettings.range[0])/2.0" |
There was a problem hiding this comment.
It's possible for both typeSettings.steps and typeSettings.range to be undefined and the slider breaks. Probably best to make one or the other mandatory when creating the slider.
| :min="typeSettings.range[0]" | ||
| :max="typeSettings.range[1]" |
There was a problem hiding this comment.
We either need to make the range required or have a default value
I think that's okay because I can't guarantee that the new range contains the old value. We auto set a range when they swap so that is why the value changes. Ideally this should be set up in the configuration file once and then values are undefined/0 until the user sets them on a specific track/detection attribute. |
editorobject which can include future visualization options for attributescoloroption for the attribute timeline/filtering toolsAttributesSlider.mp4