fixing detections afterTrack logic #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marySalvi
approved these changes
Jul 15, 2022
Collaborator
marySalvi
left a comment
There was a problem hiding this comment.
Looks good to me, error no longer appears in single camera continuous detection mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1272
Issue was caused by using getAnyTrack with a trackId that doesn't exists.
Original intention was that this was being used for creating a track in another camera where the original track already had a trackId. This code was just grabbing the type of the source camera track to make sure they aligned.
The newTracksettingsAfterLogic when the user is in Continuous detection mode uses a new overrideId by grabbing a new trackId to assign to the new Track. When in singlecam the new trackId doesn't exist already so you get the error. Swapping this to
getAnyPossibleTrackwill return an undefined if it is not located and will revert back to the default track type instead of trying to match it up.ContinuousSmall.mp4