1.9 Activity Group Support #1247
Conversation
* Activity Groups * Move Image Enhancement * wip * GroupItem * Refactor Filter Controls * Complete backend support for activity groups with migrations * Refactor of GroupStore, Filter Controls, Filter List * Group filtering support * test fixes * sidebar * sidebar update * Respond to comments * Fix tests * fixing final test (#1234) Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
* WIP Group Creation * Edit type and select. Refactor TypePicker * Progress toward creation and editing of activity groups * Group membership add and remove
* Progress on activity group editing * Progress on correct editing behavior * Finalize editing * Documentation updates * Update documentation * Add shortcut docs * Wip * KPF import support desktop * icon * Fix docs add tests * whatdo * Remove multi-file inputs * Upgrade node for electron-builder * Respond to comments * Backend fixes * Add readOnlyMode to TypePicker in GroupList
* Work in progress * Finalize KPF support * Fully move to new annotation schema in all parsers * Liint fix * Add extra meta in zip extraction
BryonLewis
left a comment
There was a problem hiding this comment.
Building passes, integration tests pass, basic testing and loading of regular data and group data works properly, checked pipelines.
Just some general comments looking at this anew, I don't think any of these are blockers:
Maybe the dropdown for the sidebar context should be made a bit clearer. It's a bit hard to tell that it is a dropdown that can be toggled through different selections by default without any box around it, just the small down arrow.
If you delete the tracks and you try to select groups it rightfully throws an error in the console. It doesn't break anything but is this something we should inform the user about? That they are selecting groups which don't have any tracks associated with them or should we place that more on the user to realized that.
You can technically create a track without official bounds. If you go to great a new track and it is in edit mode and then immediately hit 'G' to do group, it creates the track without bounds and assigns it to the group. The only way to add bounds to it is to kick it into Editing mode and add complete the drawing of the track.
Merge 1.9 feature branch into
main.