Skip to content

Desktop Attempts to Convert All files #1545

@BryonLewis

Description

@BryonLewis

Describe the bug
When in Desktop mode and importing images it attempts to convert files that don't need any conversion or check process. I.E. images that are .png or .jpg it attempts to conver but the mediaList for conversion is empty so it throws an error.
To Reproduce
Steps to reproduce the behavior:

  1. Load any image folder with a single jpg or png inside of it in the desktop version of DIVE
  2. Notice the error that happens when it attempts to index the list for the ffmpeg conversion

Expected behavior
When the data requires no conversion a Job shouldn't be kicked off at all, it should just load the DIVE Dataset and display it.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]

Additional context
There was a change to the finalizeMediaImport function which has it always return a ConversionArgs (job conversion arguments). We need to check the args.mediaList and see if it is empty. If it is empty we can just save the data and open the folder instead of kicking off a job.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions