feat: Allow custom EventLoopGroup and Timeout#78
Merged
Conversation
| return result | ||
| } | ||
| set { | ||
| _globalELG = newValue |
...to avoid naming clash with Kitura-NIO
djones6
commented
Nov 4, 2019
| } | ||
|
|
||
| fileprivate static var _globalELG: EventLoopGroup? | ||
| fileprivate static var _globalELGIsSet: Atomic<Int> = .init(value: 0) |
Contributor
Author
There was a problem hiding this comment.
This is not on a hot path, so just use a DispatchQueue
djones6
commented
Nov 4, 2019
| return _globalELGSetter.sync { | ||
| if let result = _globalELG { return result } | ||
| #if os(Linux) | ||
| let numberOfCores = Int(linux_sched_getaffinity_sr()) |
Contributor
Author
There was a problem hiding this comment.
Probably overkill for SwiftyRequest, just use System.coreCount for now
ianpartridge
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
EventLoopGroupto use 1 thread per available processor,eventLoopGroupinit parameter,timeout: HTTPClient.Configuration.Timeoutparameter toRestRequest.init(),Also updates the version of
async-http-clientto 1.0.0 (resolves #79)Motivation
RestRequestcurrently uses a global EventLoopGroup containing a single thread. This is sufficient for simple applications, however for highly parallel applications it creates a bottleneck.Also, there is currently no way to configure the timeout for requests, and HTTPClient's default is to set no timeouts. This could leave an application stuck indefinitely.