Conversation
ianpartridge
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #42
RestRequest provides two ways to configure the query parameters for the request: one is by setting the
queryItemsfield, the other is by passing them to one of thefunc responseXXX(..., queryItems:)functions.If the
queryItemsparam is not provided, it defaults tonil. However, that then unconditionally overwrites the values on the RestRequest. This seems counter-intuitive, and means the only way to use the currently configured queryItems would be to pass it as a parameter, ie.request.responseObject(..., queryItems: request.queryItems).This PR makes the overwriting conditional on the queryItems param being non-nil.
Following this change, it is no longer possible to (explicitly or implicitly) pass
queryItems: nilto clear the current query parameters. Instead, the user should setrequest.queryItems = nilbefore calling aresponsefunction.