feat: Add support for client certificates#43
Merged
ianpartridge merged 4 commits intomasterfrom Dec 19, 2018
Merged
Conversation
Sources/KituraKit/Client.swift
Outdated
| /// An initializer to set up a custom KituraKit instance on a specified route using a URL | ||
| /// - Parameter baseURL: The custom route KituraKit points to during REST requests. | ||
| public init(baseURL: URL) { | ||
| public init(baseURL: URL, containsSelfSignedCert: Bool? = false, clientCertificate: ClientCertificate? = nil) { |
Contributor
There was a problem hiding this comment.
Why is containsSelfSignedCert an optional? if it is nil it seems to just default to false?
Sources/KituraKit/Client.swift
Outdated
| // MARK: Initializers | ||
|
|
||
| /// An initializer to set up a custom KituraKit instance on a specified route using a URL | ||
| /// - Parameter baseURL: The custom route KituraKit points to during REST requests. |
Contributor
There was a problem hiding this comment.
Can you add jazzy docs comments for the new init parameters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, KituraKit does not support client certificates, or self-signed client certificates. This functionality is available in SwiftyRequest though, so enabling it is a matter of some plumbing.
We add a
public struct ClientCertificateto avoid exposing the SwiftyRequest type in the KituraKit public API.Also update the repo to Swift 4.2.1 and broaden the Travis testing.