Skip to content

Decode RequestError body#30

Merged
djones6 merged 8 commits intodevelopfrom
add_requesterror_body_develop
May 11, 2018
Merged

Decode RequestError body#30
djones6 merged 8 commits intodevelopfrom
add_requesterror_body_develop

Conversation

@djones6
Copy link
Copy Markdown
Contributor

@djones6 djones6 commented May 2, 2018

Replacement PR for #18 targeting the develop branch.

Add support for populating/decoding the body of a RequestError.

Requires: Kitura/SwiftyRequest#18 (SwiftyRequest 1.1.2) and Kitura/Kitura#1214 (Kitura 2.3).

@djones6 djones6 mentioned this pull request May 2, 2018
Closed
@djones6 djones6 requested a review from ianpartridge May 2, 2018 13:24
@djones6
Copy link
Copy Markdown
Contributor Author

djones6 commented May 2, 2018

@ianpartridge You've already reviewed this under #18 - this requires a new minor of Kitura (2.3) for the tests to pass, and I've taken the opportunity to also remove the minor constraints and update to Swift 4.1.

We should also think about what version this should be tagged as.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 2, 2018 •
edited
Loading

Codecov Report

Merging #30 into develop will increase coverage by 8.18%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    71.96%   80.15%   +8.18%     
===========================================
  Files            2        2              
  Lines          132      131       -1     
===========================================
+ Hits            95      105      +10     
+ Misses          37       26      -11
Flag Coverage Δ
#KituraKit 80.15% <80%> (+8.18%) ⬆️
Impacted Files Coverage Δ
Sources/KituraKit/Client.swift 83.33% <80%> (+7.3%) ⬆️
Sources/KituraKit/RequestErrorExtension.swift 45.45% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6ebdb...d897d40. Read the comment docs.

@djones6 djones6 force-pushed the add_requesterror_body_develop branch from 883cd77 to a38da88 Compare May 3, 2018 15:54
@djones6 djones6 force-pushed the add_requesterror_body_develop branch from a38da88 to 7de3d0f Compare May 3, 2018 16:03
@djones6
Copy link
Copy Markdown
Contributor Author

djones6 commented May 4, 2018

@ddunn2 can you confirm whether we need to specify the linux dist in the .travis.yml for the additional jobs?

ianpartridge
ianpartridge reviewed May 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tests/KituraKitTests/MainTests.swift Outdated
XCTAssertEqual(Status("Boo"), conflict)
}
}
expectation1.fulfill()
Copy link
Copy Markdown
Contributor

@ianpartridge ianpartridge May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation. (same in other tests below)

@djones6 djones6 merged commit 7d86140 into develop May 11, 2018
@djones6 djones6 deleted the add_requesterror_body_develop branch May 11, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianpartridge ianpartridge ianpartridge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djones6 @codecov-io @ianpartridge @tunniclm