Skip to content

Remove old directories before copy#29

Merged
ianpartridge merged 1 commit intodevelopfrom
script-fix
Apr 24, 2018
Merged

Remove old directories before copy#29
ianpartridge merged 1 commit intodevelopfrom
script-fix

Conversation

@DunnCoding
Copy link
Copy Markdown
Collaborator

This PR is to ensure we clear out all of the old source code on the pod branch before we copy over the new code.
This is to resolve an issue where a file name changed and the update.sh script treated it as a new file and copied it over causing an error when trying to use KituraKit in a project.

@DunnCoding DunnCoding requested a review from ianpartridge April 18, 2018 12:11
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #29 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #29   +/-   ##
========================================
  Coverage    71.96%   71.96%           
========================================
  Files            2        2           
  Lines          132      132           
========================================
  Hits            95       95           
  Misses          37       37
Flag Coverage Δ
#KituraKit 71.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9408234...a655d2d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how have you tested it?

@ianpartridge ianpartridge merged commit 2a6ebdb into develop Apr 24, 2018
@ianpartridge ianpartridge deleted the script-fix branch April 24, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants