Descriptive error handling additions#24
Merged
ianpartridge merged 2 commits intomasterfrom Apr 10, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 2 2
Lines 132 132
=======================================
Hits 95 95
Misses 37 37
Continue to review full report at Codecov.
|
Contributor
|
These are a definite improvement! Can we guide the user a bit more about how they might handle the errors if they see them? |
Contributor
Author
|
Sure, added brief guidance on how the user may handle the errors. |
Contributor
|
Nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added better error handling (descriptions) to avoid using 'unknown' in errors which could be vague for users, especially those getting the error when the client wasn't connected to the server.