Skip to content

filter out unwanted import statements#22

Merged
nhardman merged 1 commit intodevelopfrom
remove-imports
Feb 19, 2018
Merged

filter out unwanted import statements#22
nhardman merged 1 commit intodevelopfrom
remove-imports

Conversation

@nhardman
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@8ce52cd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #22   +/-   ##
==========================================
  Coverage           ?   71.96%           
==========================================
  Files              ?        2           
  Lines              ?      132           
  Branches           ?        0           
==========================================
  Hits               ?       95           
  Misses             ?       37           
  Partials           ?        0
Flag Coverage Δ
#KituraKit 71.96% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce52cd...9be7d25. Read the comment docs.

ci/update.sh Outdated
sed -i '/import LoggerAPI/d' Extensions.swift
sed -i '/import LoggerAPI/d' QueryEncoder.swift
sed -i '/import LoggerAPI/d' QueryDecoder.swift
declare -a SWIFTFILES=("Client.swift"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create this list of files at runtime instead of hard-coding?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced with a find statement that will return an array of swift file names

@nhardman nhardman merged commit b69a9a7 into develop Feb 19, 2018
@nhardman nhardman deleted the remove-imports branch February 19, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants